PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Sorting uniques by phys or chaos taken falls back to name sorting
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
How is Path of Building expected to behave?
The highest item of the list is the one that gives the most value of the specified criteria - e.g. max phys taken. Subsequent items are sorted following the same criteria.
How does Path of Building behave?
The highest item on the list is Abberath's Hooves, then Abberath's Horn, etc.
How to reproduce the issue
- Open PoB on a new (empty) build.
- Sort uniques by phys taken.
Character build code
No response
Screenshots
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in Path of Building with a new empty build, then inspect the unique-item sorting entry point; no file or test is named in the report. Compare sorting by phys taken with the expected descending criteria order, and consider the issue done when subsequent items follow that criterion instead of falling back to name sorting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100