PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

FullDPS Corrupting Blood Incorrect Stack behaviour

Open
#6,437 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

After #6436 corrupting blood from multiple sources no longer stacks

Ingame there is a limit of 10 Corrupted Blood stacks, these can come from any mixture of sources, in PoB we only apply the source with the highest dps, regardless of how many leftover stacks it leaves

This for instance breaks multiple different sources of corrupting cry, or a mixture of corrupting cry with corrupting fever, it also breaks full dps count multipliers

The intended behavior is for full dps to add stacks of the highest source multiplied by its fulldps count, and then to only take the 10 highest stacks of it (eg if 8 corrupting cry and 4 corrupting fever stacks, and cry is higher than fever it should apply 8 from corrupting cry and only 2 from corrupting fever, or if corrupting cry count 4 on 2 warcries to allow both)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace the FullDPS Corrupting Blood stack calculation and compare its behavior with the change in #6436. Verify that stacks from multiple sources and full-dps counts are combined, then limited to the 10 highest stacks, including the mixed-source examples described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.