PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

[dev] MH hit damage doesn't work with winds of fate

Open
#5,470 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
How is Path of Building expected to behave?

MH hit damage should look appropriate even with winds of fate equipped.

How does Path of Building behave?

image

How to reproduce the issue

No response

Character build code
https://pobb.in/MCD6Rlt0HAig
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by loading the linked PoB build code and comparing the displayed main-hand hit damage with Winds of Fate equipped; use the screenshot and checked changelog to establish the reported state. Reproduce the mismatch before tracing the relevant damage calculation, then add a focused regression test if the project provides one; done means the main-hand hit damage is correct with Winds of Fate.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.