PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

[Feature Request] Add option to calculate Elemental Overload damage based on expected uptime

Abierto
#4,887 2 comentarios 1 reacción 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

enhancement
Lenguaje dominante
Lua
Estrellas
5.4k
Forks
2.4k
Merge medio
1 d 12 h
PR fusionados (30 d)
26

Descripción

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

Currently, the damage calculator assumes that Elemental Overload has 100% uptime when it is allocated, regardless of a skill's critical strike chance. This is unrealistic and misleading for skills with low hit frequencies and critical strike chance, or skills supported by Controlled Destruction. When sorting support gems by DPS gain, Controlled Destruction is listed highly despite being a damage loss in reality.

Describe the solution you'd like

Add a toggle in the config tab that allows users who have allocated Elemental Overload (EO) to select between two options for EO estimation: "Always active" and "Expected uptime". "Always active" should replicate current behaviour. "Expected uptime" should scale the modifier from EO based on the following (or a similar) formula:

EO = 40% * min[1; Hit Rate * Effective Crit Chance * 8 * (1 + Total EO Increase)]

wherein Effective Crit Chance respects accuracy for attacks, and Total EO Increase refers to effects like temporal chains on the player.

"Expected uptime" should be the default selection, so users unaware of the mechanism of EO are not misleadingly pointed to options like Controlled Destruction.

This calculation is still not accurate for builds that involve a rotation of multiple skills, like Hexblast, and for any other situation in which players are not hitting for any period of time, but it's no longer as misleading as the current behaviour.

Describe alternatives you've considered

No response

Additional context

No response

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza en la pestaña de config y en el punto de entrada del cálculo de daño de Elemental Overload; el payload no nombra archivos ni tests específicos. Traza cómo se trata actualmente EO como siempre activo, luego define los dos modos de estimación seleccionables y verifica que la fórmula de uptime esperado afecte al daño y a la configuración predeterminada según lo solicitado.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
lua
Área
game-dev
Tipo de issue
Nueva funcionalidad
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.