PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
[Feature Request] Add option to calculate Elemental Overload damage based on expected uptime
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Lua
- Sterne
- 5.4k
- Forks
- 2.4k
- Ø Merge
- 1 T. 12 Std.
- Gemergte PRs (30 T.)
- 26
Beschreibung
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?
Currently, the damage calculator assumes that Elemental Overload has 100% uptime when it is allocated, regardless of a skill's critical strike chance. This is unrealistic and misleading for skills with low hit frequencies and critical strike chance, or skills supported by Controlled Destruction. When sorting support gems by DPS gain, Controlled Destruction is listed highly despite being a damage loss in reality.
Describe the solution you'd like
Add a toggle in the config tab that allows users who have allocated Elemental Overload (EO) to select between two options for EO estimation: "Always active" and "Expected uptime". "Always active" should replicate current behaviour. "Expected uptime" should scale the modifier from EO based on the following (or a similar) formula:
EO = 40% * min[1; Hit Rate * Effective Crit Chance * 8 * (1 + Total EO Increase)]
wherein Effective Crit Chance respects accuracy for attacks, and Total EO Increase refers to effects like temporal chains on the player.
"Expected uptime" should be the default selection, so users unaware of the mechanism of EO are not misleadingly pointed to options like Controlled Destruction.
This calculation is still not accurate for builds that involve a rotation of multiple skills, like Hexblast, and for any other situation in which players are not hitting for any period of time, but it's no longer as misleading as the current behaviour.
Describe alternatives you've considered
No response
Additional context
No response
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne im config-Tab und am Einstiegspunkt der Schadensberechnung von Elemental Overload; die Payload nennt keine spezifischen Dateien oder Tests. Verfolge, wie EO derzeit als immer aktiv behandelt wird, definiere dann die zwei auswählbaren Schätzmodi und überprüfe, dass die Formel für die erwartete Uptime den Schaden und die Standardeinstellung wie angefordert beeinflusst.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- lua
- Bereich
- game-dev
- Issue-Typ
- Feature
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100