PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Warcry Calculation Mode Is Incorrect
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Lua
- Estrellas
- 5.4k
- Forks
- 2.4k
- Merge medio
- 1 d 12 h
- PR fusionados (30 d)
- 26
Descripción
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?
When im looking at the configuration by default warcry mode is set to "Max hit"
Now I only have 1 warcry on my POB, Infernal Cry
What it's supposed to do is simply - cover enemies in ash (this does not stack and it's inc fire dmg taken is based on the warcry power)
It also "combusts" which is a hit that deals 157% of base with 60% converted to fire
So it should NOT be getting more powerful or more dmg when reaching the "final" exert
Max Hit on Warcry calculation mode shows "Shows maximum hit for lining up all warcries"
When I put it on average my ignite dps PLUMMETS to nearly nothing
On max, my ignite dps is absolutely monstrous
If I disable infernal cry then the warcry calculation mode is gone and my dps is massive
So the "Average" mode for warcry calculation is completely bugged/useless
The "Max" might be working properly but I really don't know
What is the actual behaviour/value?
When I select Warcry Calculation mode and put it on avg it destroys my damage values
Less dmg than turning the warcry off completely, which makes no sense
How to reproduce the issue
Set a melee ignite build pob
Enable any war cry
Go to Calc and set warcry mode to avg instead of max
Watch dps plummet to nothing
Character build code
https://pastebin.com/jBmsyc6M
Screenshots
No response
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Reproduce el problema con la build de Pastebin enlazada: activa un warcry, abre Calc y compara los modos average y max de Warcry Calculation. Sigue la ruta de cálculo de Infernal Cry y de los demás warcries; se considera terminado cuando el modo average ya no reduce de forma inverosímil el daño de Ignite y los modos de warcry coinciden con su comportamiento documentado.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- lua
- Área
- game-dev
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100