PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Warcry Calculation Mode Is Incorrect
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?
When im looking at the configuration by default warcry mode is set to "Max hit"
Now I only have 1 warcry on my POB, Infernal Cry
What it's supposed to do is simply - cover enemies in ash (this does not stack and it's inc fire dmg taken is based on the warcry power)
It also "combusts" which is a hit that deals 157% of base with 60% converted to fire
So it should NOT be getting more powerful or more dmg when reaching the "final" exert
Max Hit on Warcry calculation mode shows "Shows maximum hit for lining up all warcries"
When I put it on average my ignite dps PLUMMETS to nearly nothing
On max, my ignite dps is absolutely monstrous
If I disable infernal cry then the warcry calculation mode is gone and my dps is massive
So the "Average" mode for warcry calculation is completely bugged/useless
The "Max" might be working properly but I really don't know
What is the actual behaviour/value?
When I select Warcry Calculation mode and put it on avg it destroys my damage values
Less dmg than turning the warcry off completely, which makes no sense
How to reproduce the issue
Set a melee ignite build pob
Enable any war cry
Go to Calc and set warcry mode to avg instead of max
Watch dps plummet to nothing
Character build code
https://pastebin.com/jBmsyc6M
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with the linked Pastebin build: enable a warcry, open Calc, and compare the average and max Warcry Calculation modes. Trace the calculation path for Infernal Cry and other warcries; done means average mode no longer reduces ignite damage implausibly and the warcry modes match their documented behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100