PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Death Wish Skill Calculation Fix

Abierto
#4,462 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

enhancement
Lenguaje dominante
Lua
Estrellas
5.4k
Forks
2.4k
Merge medio
1 d 12 h
PR fusionados (30 d)
26

Descripción

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

The Death Wish skill actualy has two damage components and not just one, but PoB only calculates one (and with wrong parameters).

There are mixed damages, one is base fire damage from the skill and then secondly the minion explosion (this explosion cannot be reflected but the base one can).

The base is buffed by spell damage increases, and fire.

Explosion Poof
Explosion poof 2

As evidenced by enabling and disabling Herald of Fire, or even zealotry as seen here
Explosion wrath
Explosion wrath 2

However, in POB neither aura increases damage, or crit chance even though spell crit chance increases crit as seen above.
And increasing the health or levels of minions doesn't increase the calculated damage in pob, neither can you select which minions that explode.

As is, the Death Wish skill doesn't calculate correctly and actually does way different damage as written in PoB.

Describe the solution you'd like

Dividing the damage components of Death Wish Base damage and minion explosion, and enabling choice of what minion explodes.
Fixing so increasing health and levels of minion will add damage to the minion explosion.
Adding so spell damage and elemental damage increases adds damage to the base explosion.
Adding that spell crit chance also increases crit chance of the spell.

Describe alternatives you've considered

The alternative is using a spread sheet of minions and adding life to them, finding the base damage of the death wish explosion, and adding them toghether in one boom. Not happening...

Additional context

No response

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Empieza rastreando el punto de entrada del cálculo de la habilidad Death Wish en Path of Building e identifica cómo se calcula su componente de daño único actual. Compara ese comportamiento con los componentes solicitados de fuego base y explosión del esbirro, incluida la selección del esbirro, el escalado de vida y nivel, el daño de hechizos y elemental, y la probabilidad de golpe crítico de los hechizos. Se considera terminado cuando la calculadora representa ambos componentes y refleja correctamente esos modificadores.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
lua
Área
game-dev
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
30/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.