PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Death Wish Skill Calculation Fix

Open
#4,462 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

The Death Wish skill actualy has two damage components and not just one, but PoB only calculates one (and with wrong parameters).

There are mixed damages, one is base fire damage from the skill and then secondly the minion explosion (this explosion cannot be reflected but the base one can).

The base is buffed by spell damage increases, and fire.

Explosion Poof
Explosion poof 2

As evidenced by enabling and disabling Herald of Fire, or even zealotry as seen here
Explosion wrath
Explosion wrath 2

However, in POB neither aura increases damage, or crit chance even though spell crit chance increases crit as seen above.
And increasing the health or levels of minions doesn't increase the calculated damage in pob, neither can you select which minions that explode.

As is, the Death Wish skill doesn't calculate correctly and actually does way different damage as written in PoB.

Describe the solution you'd like

Dividing the damage components of Death Wish Base damage and minion explosion, and enabling choice of what minion explodes.
Fixing so increasing health and levels of minion will add damage to the minion explosion.
Adding so spell damage and elemental damage increases adds damage to the base explosion.
Adding that spell crit chance also increases crit chance of the spell.

Describe alternatives you've considered

The alternative is using a spread sheet of minions and adding life to them, finding the base damage of the death wish explosion, and adding them toghether in one boom. Not happening...

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the Death Wish skill calculation entry point in Path of Building and identify how its current single damage component is computed. Compare that behavior with the requested base-fire and minion-explosion components, including minion selection, life and level scaling, spell and elemental damage, and spell critical chance. Done means the calculator represents both components and reflects those modifiers correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.