PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

calc and or show condition for "by you" and "by summon", "by summon with item/skill effect"

Open
#4,218 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

may be "condition" in "calcs"-"skill hit damage"-"effective dps mod"-"enemy modifiers"-"notes" must say like "Ignited by you" and "Ignited by any" ?

i have Combustion with my summon and was confused that the checkmark "enemy ignited" works both on the Combustion's ignite from summon and on the "Snowforged" ignite from me

idk can it calc separately Ignited by summon with Combustion and any Ignited by me

ps: for minions debuff Elemental Army Support: Minions from Supported Skills inflict Exposure on Hit, applying -10% to the Elemental Resistance matching
now calc use for it Elemental Mastery: Exposure you inflict applies at least -18% to the affected Resistance and Fire Mastery: Fire Exposure you inflict applies an extra -5% to Fire Resistance but i think it wrong (idk how to test it)

Describe the solution you'd like

separate debuffs from minions like it is now for Skitterbots's shock+chill and Corpse Pact's shock+chill

  1. add checkboxe like "Combustion affected ignite" (not used as "is ignited", only "have -10% to Fire Resistance")
  2. add checkboxes "status from minion" for status what can be affected/modified from passives (and items/skills?) or autocalc it
  3. add "notes" text like "Ignited by you"

idk, it's hard ticket

Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the Calcs > Skill Hit Damage > Effective DPS Mod > Enemy Modifiers conditions described in the issue, and reproduce how an ignite from a summon and one from the player are currently treated. Compare the existing Skitterbots and Corpse Pact handling, then define completion as correctly distinguishing player- and minion-applied debuffs and showing the relevant notes or conditions.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.