Counter attack skills are scaling with AS

Check version

• I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• I've checked for duplicate issues by using the search function of the issue tracker

What is the expected behaviour/value?

Calculation of Full DPS for counter attack skills (Riposte, Reckoning, Vengeance) should not scale with attack speed - attack rate should depend on their cooldown or user input (if specified).

What is the actual behaviour/value?

Attack rate for counter attack skills is scaling with attack speed and can be higher than cooldown allows it...

How to reproduce the issue

1. Select Vengeance as main skill
2. Check its attack rate
3. Put some points into attack speed in tree
4. Check Vengeance attack rate again

Attack rate for this skill is based on it cooldown and on how many you can proc it.

Build code

https://pastebin.com/RSh5uLM3

Screenshots

1: Low DPS

• Vengeance lvl 1 with some weapon
• Clean skill tree
• No other gems
• Precision lvl 40 to get 100% hit chance

2: High DPS

• Vengeance lvl 1 with same weapon
• Only as from skill tree (same dmg per hit)
• Faster attacks lvl 40
• Precision lvl 40 to get 100% hit chance

Riproduci il problema con Vengeance come abilità principale, quindi confronta la sua velocità d’attacco e il suo Full DPS prima e dopo l’aggiunta della velocità d’attacco. Traccia il percorso di calcolo di Vengeance, Riposte e Reckoning e determina in che modo i cooldown o l’input dell’utente dovrebbero limitare la velocità d’attacco. Il lavoro è completato quando la velocità d’attacco non aumenta più le frequenze dei contrattacchi oltre il loro cooldown o la loro frequenza di attivazione configurata.