PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
DPS comparison does not apply certain buffs and debuffs to Total Mirage DPS.
Nessuno ha ancora preso questa issue.
- Lingua principale
- Lua
- Stelle
- 5.4k
- Fork
- 2.4k
- Merge medio
- 1g 12h
- PR unite (30g)
- 26
Descrizione
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?
The comparison preview should report proportional (same percentage) changes in 'Total/DoT DPS' and 'Total Mirage DPS'. In particular, when considering a change that has no effect on dps, the comparison preview shouldn't mention dps changes at all.
What is the actual behaviour/value?
If certain damage buffs or debuffs are applied, comparison previews will calculate the difference between current Mirage DPS numbers as displayed on the left (which properly includes those buffs and debuffs) and its newly calculated Mirage DPS (which does not include aforementioned buffs and debuffs).
Examples of effects that create this behavior: Frenzy charges, Empower support, I don't know if there are any others
Examples that do not create this behavior: Malevolence, Despair
I also want to mention Tailwind, which doesn't create issues overall, but its effect specifically doesn't show up in the comparison when allocating or deallocating Gathering Winds. Same goes for the Corruption passive.
How to reproduce the issue
- Equip a bow.
- Slot Toxic Rain supported by Mirage Archer.
- Click on the minor passive directly before Disciple of the Slaughter.
- Spec and unspec Disciple of the Slaughter to compare DPS comparison with actual effect on DPS numbers on left.
- Hover an unrelated passive to see unexpected effect on Mirage DPS.
- Slot Empower with Toxic Rain and Mirage Archer to see the same effect.
Build code
https://pastebin.com/9B366mi7
Screenshots



Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Direzione di ricerca
Inizia riproducendo l’anteprima del confronto con il codice della build fornito, Toxic Rain, Mirage Archer, Frenzy charges ed Empower, seguendo i passaggi elencati. Il payload non indica file sorgente né test, quindi ricostruisci il calcolo del confronto a partire dal comportamento dell’anteprima; il lavoro è completato quando il DPS di Mirage riflette gli stessi buff e debuff del DPS Total/DoT e le modifiche non correlate non segnalano differenze false.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- lua
- Ambito
- game-dev
- Tipo di issue
- Bug
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 35/100