PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

DPS comparison does not apply certain buffs and debuffs to Total Mirage DPS.

Abierto
#3,429 5 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

bug
Lenguaje dominante
Lua
Estrellas
5.4k
Forks
2.4k
Merge medio
1 d 12 h
PR fusionados (30 d)
26

Descripción

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

The comparison preview should report proportional (same percentage) changes in 'Total/DoT DPS' and 'Total Mirage DPS'. In particular, when considering a change that has no effect on dps, the comparison preview shouldn't mention dps changes at all.

What is the actual behaviour/value?

If certain damage buffs or debuffs are applied, comparison previews will calculate the difference between current Mirage DPS numbers as displayed on the left (which properly includes those buffs and debuffs) and its newly calculated Mirage DPS (which does not include aforementioned buffs and debuffs).

Examples of effects that create this behavior: Frenzy charges, Empower support, I don't know if there are any others
Examples that do not create this behavior: Malevolence, Despair

I also want to mention Tailwind, which doesn't create issues overall, but its effect specifically doesn't show up in the comparison when allocating or deallocating Gathering Winds. Same goes for the Corruption passive.

How to reproduce the issue
  1. Equip a bow.
  2. Slot Toxic Rain supported by Mirage Archer.
  3. Click on the minor passive directly before Disciple of the Slaughter.
  4. Spec and unspec Disciple of the Slaughter to compare DPS comparison with actual effect on DPS numbers on left.
  5. Hover an unrelated passive to see unexpected effect on Mirage DPS.
  6. Slot Empower with Toxic Rain and Mirage Archer to see the same effect.
Build code
https://pastebin.com/9B366mi7
Screenshots

PoB_Issue
PoB_Issue1
PoB_Issue2

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Empieza reproduciendo la vista previa de comparación con el código de build proporcionado, Toxic Rain, Mirage Archer, Frenzy charges y Empower, siguiendo los pasos indicados. El payload no menciona archivos fuente ni tests, así que sigue el cálculo de la comparación a partir del comportamiento de la vista previa; se considera terminado cuando el DPS de Mirage refleja los mismos buffs y debuffs que el DPS de Total/DoT y los cambios no relacionados no informan de diferencias falsas.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
lua
Área
game-dev
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.