PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
DPS comparison does not apply certain buffs and debuffs to Total Mirage DPS.
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?
The comparison preview should report proportional (same percentage) changes in 'Total/DoT DPS' and 'Total Mirage DPS'. In particular, when considering a change that has no effect on dps, the comparison preview shouldn't mention dps changes at all.
What is the actual behaviour/value?
If certain damage buffs or debuffs are applied, comparison previews will calculate the difference between current Mirage DPS numbers as displayed on the left (which properly includes those buffs and debuffs) and its newly calculated Mirage DPS (which does not include aforementioned buffs and debuffs).
Examples of effects that create this behavior: Frenzy charges, Empower support, I don't know if there are any others
Examples that do not create this behavior: Malevolence, Despair
I also want to mention Tailwind, which doesn't create issues overall, but its effect specifically doesn't show up in the comparison when allocating or deallocating Gathering Winds. Same goes for the Corruption passive.
How to reproduce the issue
- Equip a bow.
- Slot Toxic Rain supported by Mirage Archer.
- Click on the minor passive directly before Disciple of the Slaughter.
- Spec and unspec Disciple of the Slaughter to compare DPS comparison with actual effect on DPS numbers on left.
- Hover an unrelated passive to see unexpected effect on Mirage DPS.
- Slot Empower with Toxic Rain and Mirage Archer to see the same effect.
Build code
https://pastebin.com/9B366mi7
Screenshots



Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the comparison preview with the provided build code, Toxic Rain, Mirage Archer, Frenzy charges, and Empower, following the listed steps. The payload names no source files or tests, so trace the comparison calculation from the preview behavior; done means Mirage DPS reflects the same buffs and debuffs as Total/DoT DPS and unrelated changes do not report false differences.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100