PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Change to how the Storm Rain DPS calculation works

Offen
#3,158 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

enhancement good first issue
Vorherrschende Sprache
Lua
Sterne
5.4k
Forks
2.4k
Ø Merge
1 T. 12 Std.
Gemergte PRs (30 T.)
26

Beschreibung

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

Yes, it is. Currently it is impossible to correctly set the amount of the beams for various sources of the skill.

Describe the solution you'd like

A new calculation for the beams amount and DPS would solve all the issues. Each instance should calculate beams and DPS (beams are the main source of damage) separately in the following way:

a=average beam damage
x=arrow count (amount of arrows that are fired)
y=attack speed (how many attacks are performed in a second)
z=duration (how many beams total are present in a single second of attacking [note each arrow can generate 4 beams])

DPS=(x*y*z)*a
e.g.
DPS=(6*3*2.5)*100k

In the above scenario the calculation automatically figures out - unless otherwise selected in the window that was implemented - what our DPS with storm rain is.

6 arrows are fired every time an attack is performed. The attack is performed 3 times each second. In a single second, each arrow can produce 2.5 beams at level 21 gem (beams pulse every 0.4s).
This means we can have 18 arrows on the ground that will pulse 2.5 times in a second, totaling 4,5mil dps.

In my particular example based on my current build, my ballistae totems fire 4 arrows with 3.5 attack speed. I have gem level 21 with 40% pulse frequency helmet enchantment, which would result in:
DPS=(4*3.5*4.16)*200k
DPS=11,648mil
Note that the frequency can be further increased with alternate quality gem, which I do not have.

This would also improve the overall skill gem feel when looking at builds using it on 3rd party tools such as poeninja.

Describe alternatives you've considered

No response

Additional context

Right now we have to do all the math ourselves to figure out how many overlapping beams we can produce, which is definitely not particularly handy.

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Das Issue nennt keine Dateien, Tests oder Einstiegspunkte. Beginne damit, die Storm Rain-Berechnung und ihre Skill-Daten zu lokalisieren, und verfolge dann, wie Pfeilanzahl, Angriffsgeschwindigkeit, Strahldauer und Pulsfrequenz derzeit dargestellt werden; abgeschlossen bedeutet, dass die vorgeschlagene DPS-Berechnung für die aufgeführten Strahlquellen funktioniert und überprüfbare Ergebnisse für die Beispiele liefert.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
lua
Bereich
game-dev
Issue-Typ
Feature
Schwierigkeit
5/5
Geschätzter Aufwand
Über eine Woche
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
25/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.