PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
trap support bypass cooldown when calculating hit DPS
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the behaviour in-game?
trap support does not modify the cooldown or rate i can throw the trap at all. it is the same with and without it, as it is still tied to the original cooldown.
What is the behaviour in Path of Building?
linking trap support to frost bomb increases hit dps substantially, despite saying it is converting my skill cooldown into trap cooldown.
it shows it has the cooldown for the trap on the skill section but is only calculating the DPS using the cast rate, ignoring cooldowns.
How to reproduce the issue
link trap support to frost bomb.
disable trap support and hover over the enable to view the hit dps change, or enable it and include it in full dps
PoB for PoE1 build code
https://pobb.in/jzYl_J4RbxmV
Screenshots
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named. Start by reproducing the Frost Bomb plus Trap Support case with the linked PoB build, then trace the hit-DPS calculation and compare it with the trap cooldown shown in the skill section; done means DPS respects the trap cooldown.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- desktop-dev, game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100