NotePlan / NotePlan/plugins

Helpers: Add hierarchy to the chooseFolder helper

Aperta
#556 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

@jgclark ci sta già lavorando.

Dal 11/4/2024.

enhancement
Lingua principale
JavaScript
Stelle
204
Fork
82
Merge medio
22h 27m
PR unite (30g)
3

Descrizione

We now use the chooseFolder helper in a lot of places. But one thing I find frustrating is that I am often filtering for something, like the word project. It shows me lots of choices for that term, and some of them are indented, and visually seem to be indented under items above them, but they actually may not be in that folder at all. So I sometimes move a note to a folder that is not actually the one I wanted.

Screen Cap 2024-04-11 at 11 14 44@2x

In the above example, you would assume all these subfolders are inside the folder "Travel", but in fact, they are not!

On the other hand, something I really like about your getFolderListMinusExclusions() function is that it solves this issue by putting the whole path in the choice. So when you filter, you actually see the whole path to that folder on the line.

Screen Cap 2024-04-11 at 11 16 28@2x

I would like to suggest/recommend that we change chooseFolder to use the format/output of getFolderListMinusExclusions() rather than making its own folder list with just icons/indents.

I guess we could make it another parameter for format, but I think the getFolderListMinusExclusions() approach is better and I would recommend we just change the chooseFolder helper to use it instead so all plugins that use it just get better.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.