NotePlan / NotePlan/plugins

Helpers: Add hierarchy to the chooseFolder helper

Offen
#556 0 Kommentare 0 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

@jgclark arbeitet bereits daran.

Seit 11.4.2024.

enhancement
Vorherrschende Sprache
JavaScript
Sterne
204
Forks
82
Ø Merge
22 Std. 27 Min.
Gemergte PRs (30 T.)
3

Beschreibung

We now use the chooseFolder helper in a lot of places. But one thing I find frustrating is that I am often filtering for something, like the word project. It shows me lots of choices for that term, and some of them are indented, and visually seem to be indented under items above them, but they actually may not be in that folder at all. So I sometimes move a note to a folder that is not actually the one I wanted.

Screen Cap 2024-04-11 at 11 14 44@2x

In the above example, you would assume all these subfolders are inside the folder "Travel", but in fact, they are not!

On the other hand, something I really like about your getFolderListMinusExclusions() function is that it solves this issue by putting the whole path in the choice. So when you filter, you actually see the whole path to that folder on the line.

Screen Cap 2024-04-11 at 11 16 28@2x

I would like to suggest/recommend that we change chooseFolder to use the format/output of getFolderListMinusExclusions() rather than making its own folder list with just icons/indents.

I guess we could make it another parameter for format, but I think the getFolderListMinusExclusions() approach is better and I would recommend we just change the chooseFolder helper to use it instead so all plugins that use it just get better.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.