NotePlan / NotePlan/plugins

Helpers: Add hierarchy to the chooseFolder helper

Abierto
#556 0 comentarios 0 reacciones 1 asignado Ver en GitHub

@jgclark ya está trabajando en esto.

Desde el 11/4/2024.

enhancement
Lenguaje dominante
JavaScript
Estrellas
204
Forks
82
Merge medio
22 h 27 min
PR fusionados (30 d)
3

Descripción

We now use the chooseFolder helper in a lot of places. But one thing I find frustrating is that I am often filtering for something, like the word project. It shows me lots of choices for that term, and some of them are indented, and visually seem to be indented under items above them, but they actually may not be in that folder at all. So I sometimes move a note to a folder that is not actually the one I wanted.

Screen Cap 2024-04-11 at 11 14 44@2x

In the above example, you would assume all these subfolders are inside the folder "Travel", but in fact, they are not!

On the other hand, something I really like about your getFolderListMinusExclusions() function is that it solves this issue by putting the whole path in the choice. So when you filter, you actually see the whole path to that folder on the line.

Screen Cap 2024-04-11 at 11 16 28@2x

I would like to suggest/recommend that we change chooseFolder to use the format/output of getFolderListMinusExclusions() rather than making its own folder list with just icons/indents.

I guess we could make it another parameter for format, but I think the getFolderListMinusExclusions() approach is better and I would recommend we just change the chooseFolder helper to use it instead so all plugins that use it just get better.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.