NativeScript / NativeScript/plugins

[nativescript-ui-listview] Upgrade from 10.0.0.1 to 14.2.4 breaks my list

Open
#355 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
206
Forks
123
Avg merge
2d 1h
Merged PRs (30d)
1

Description

This only happens on iOS. Android is fine. Items overlap after the upgrade.

On v10:
image

On v14
image

and the relevant code (note the issue occurs in the "pot" template):

<lv:RadListView class='event-list' row="1" height="100%" items="{{ list }}" itemTemplateSelector="{{ templateSelector }}">
        <lv:RadListView.listViewLayout>
          <lv:ListViewLinearLayout scrollDirection="Vertical" />
        </lv:RadListView.listViewLayout>
        <lv:RadListView.itemTemplates>
          <template key="promotion">
            <StackLayout class='promotion'>
              <Label text="{{  title  }}" class='title' textWrap='true' />
              <Label text="{{  description  }}" class='description' textWrap='true' />
            </StackLayout>
          </template>
          <template key="event">
            <StackLayout class="event">
              <Label col="1" class="event-name" textWrap="true">
                <FormattedString>
                  <Span text="{{name}}" />
                  <Span text=" - " />
                  <Span text="{{ humanDate(date) }}" />
                </FormattedString>
              </Label>
              <Label text="{{ 'Caller: ' + caller}}" class="event-caller" textWrap="true" />
              <Label text="{{times}}" class="event-times" textWrap="true" />
              <Label text="{{ other }}" class="event-other" visibility="{{ other ? 'visible' : 'collapsed' }}" textWrap="true" />
            </StackLayout>
          </template>
          <template key="pot">
            <StackLayout class="pot">
              <Label text="{{name}}" textWrap="true" />
              <Label class="playoff" textWrap="true" visibility="{{ playoffDate ? 'visible' : 'collapsed' }}">
                <FormattedString>
                  <span text="Playoff: " />
                  <span text="{{ humanDate(playoffDate) }}" />
                  <span text="{{ ' ' + playoffEvent }}" />
                  <span text="{{ formatPlayoffPrize(playoffPrize) }}" />
                </FormattedString>
              </Label>
              <Label class="info" text="{{info}}" textWrap="true" visibility="{{ info ? 'visible' : 'collapsed' }}" />
              <FlexboxLayout flexDirection="row" width="100%" justifyContent="space-between">
                <Repeater items="{{balls}}">
                  <Repeater.itemsLayout>
                    <StackLayout orientation="horizontal" />
                  </Repeater.itemsLayout>
                  <Repeater.itemTemplate>
                    <Image src="{{ `~/assets/images/balls-lettered/` + $value + `.png` }}" margin="10" height="50" visibility="{{ $value != '0' ? 'visible' : 'collapsed' }}" />
                  </Repeater.itemTemplate>
                </Repeater>
                <Label textAlignment="right" verticalAlignment="bottom" textWrap="true">
                  <FormattedString>
                    <Span text="{{numbers ? 'in ' + numbers + '#s or less ': ''}}" textWrap="true" textAlignment="right" />
                    <Span text="{{formatPrize(prize)}}" textAlignment="right" />
                  </FormattedString>
                </Label>
              </FlexboxLayout>
            </StackLayout>
          </template>
        </lv:RadListView.itemTemplates>


      </lv:RadListView>

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the provided RadListView markup and the pot item template, then reproduce the overlap on iOS while comparing versions 10.0.0.1 and 14.2.4. Trace the list layout and item sizing behavior; done means pot items no longer overlap on iOS while the existing Android behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, typescript
Domain
frontend, mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.