NativeScript / NativeScript/nativescript-cli

Fix cleanup request removal presence check logging

未關閉
#6,090 0 則留言 0 個 reaction 已指派 1 人 在 GitHub 檢視

@edusperoni 已經在處理了。

開始於 2026年7月25日。

主要語言
JavaScript
星號
1.1k
分支
204
平均合併
1 天 9 小時
30 天內合併 PR
8

描述

Summary

removeRequest in lib/detached-processes/cleanup-process.ts uses a self-comparison in its existence check:

  • The predicate compares currentRequestInfo with itself, so it evaluates to true whenever the request queue is non-empty.
  • The subsequent _.remove call already correctly compares each queued request against the supplied requestInfo.

As a result, removing a request that was never queued can log that it was removed when there are other queued requests. The request list itself is not incorrectly modified; the impact is limited to the success-versus-absent-request log branch.

Required change

Update the removeRequest existence predicate to compare currentRequestInfo with the incoming requestInfo, matching the predicate used by _.remove.

Affected area

  • lib/detached-processes/cleanup-process.tsremoveRequest

Acceptance criteria

  • removeRequest selects the successful-removal branch only when an equal queued request exists.
  • Removing an absent request logs the existing “cannot remove … has not been added before” message.
  • Removing an existing request continues to remove it and log the existing successful-removal message.

Context

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。