NativeScript / NativeScript/nativescript-cli
Fix cleanup request removal presence check logging
Offen
@edusperoni arbeitet bereits daran.
Seit 25.7.2026.
- Vorherrschende Sprache
- JavaScript
- Sterne
- 1.1k
- Forks
- 204
- Ø Merge
- 1 T. 9 Std.
- Gemergte PRs (30 T.)
- 8
Beschreibung
Summary
removeRequest in lib/detached-processes/cleanup-process.ts uses a self-comparison in its existence check:
- The predicate compares
currentRequestInfowith itself, so it evaluates to true whenever the request queue is non-empty. - The subsequent
_.removecall already correctly compares each queued request against the suppliedrequestInfo.
As a result, removing a request that was never queued can log that it was removed when there are other queued requests. The request list itself is not incorrectly modified; the impact is limited to the success-versus-absent-request log branch.
Required change
Update the removeRequest existence predicate to compare currentRequestInfo with the incoming requestInfo, matching the predicate used by _.remove.
Affected area
lib/detached-processes/cleanup-process.ts—removeRequest
Acceptance criteria
removeRequestselects the successful-removal branch only when an equal queued request exists.- Removing an absent request logs the existing “cannot remove … has not been added before” message.
- Removing an existing request continues to remove it and log the existing successful-removal message.
Context
- Reported during PR #6089: https://github.com/NativeScript/nativescript-cli/pull/6089
- Original review discussion: https://github.com/NativeScript/nativescript-cli/pull/6089#discussion_r3650504137
- Requested by @edusperoni.
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Bewertung
Dieses Issue wurde noch nicht bewertet.