NativeScript / NativeScript/nativescript-cli
Fix cleanup request removal presence check logging
Aberta
@edusperoni já está trabalhando nisso.
Desde 25/7/2026.
- Linguagem predominante
- JavaScript
- Estrelas
- 1.1k
- Forks
- 204
- Merge médio
- 1d 9h
- PRs com merge (30d)
- 8
Descrição
Summary
removeRequest in lib/detached-processes/cleanup-process.ts uses a self-comparison in its existence check:
- The predicate compares
currentRequestInfowith itself, so it evaluates to true whenever the request queue is non-empty. - The subsequent
_.removecall already correctly compares each queued request against the suppliedrequestInfo.
As a result, removing a request that was never queued can log that it was removed when there are other queued requests. The request list itself is not incorrectly modified; the impact is limited to the success-versus-absent-request log branch.
Required change
Update the removeRequest existence predicate to compare currentRequestInfo with the incoming requestInfo, matching the predicate used by _.remove.
Affected area
lib/detached-processes/cleanup-process.ts—removeRequest
Acceptance criteria
removeRequestselects the successful-removal branch only when an equal queued request exists.- Removing an absent request logs the existing “cannot remove … has not been added before” message.
- Removing an existing request continues to remove it and log the existing successful-removal message.
Context
- Reported during PR #6089: https://github.com/NativeScript/nativescript-cli/pull/6089
- Original review discussion: https://github.com/NativeScript/nativescript-cli/pull/6089#discussion_r3650504137
- Requested by @edusperoni.
Guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Avaliação
Esta issue ainda não foi avaliada.