NativeScript / NativeScript/nativescript-cli
sourcemap service improvements
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.1k
- Forks
- 204
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 8
Description
- If you disable sourcemaps with webpack then the cli will still translate any file if the sourcemap is present.
the cli sourcemap service should be disable when env.sourcemap is false. I found myself in the need to see the actual source files from an error. I simply couldnt, had to modify the cli code to disable the sourcemap entirely - when translating source maps the cli always adds "app" at the start as file name. This is wrong. It should only do that when it is an actual app file.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the CLI sourcemap service and inspect how env.sourcemap and translated filenames are handled. Verify behavior with sourcemaps disabled and with non-app files; done means the service does not translate when disabled and does not prepend "app" unless appropriate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100