MIT-LCP / MIT-LCP/wfdb-python

ann2rr returns ghost beats

Open
#479 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
853
Forks
322
PR merge metrics
No merged PRs in 30d

Description

Hi,

If the input file, say `atr', contains additional labels, such as (N and (AFIB, ann2rr returns surplus rr intervals at the location of these labels.

Details:
In ann2rr in hr.py the rr intervals are calculated:
rr_interval = calc_rr(ann.sample, fs=ann.fs)

ann.sample contains the beat locations + the annotation location. Hence, ann2rr splits the rr interval which spans over each annotation location into two. This changes the heart rhythm at critical points. For example, at the beginning and end of atrial fibrillation, i.e. at (AFIB and (N.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in hr.py at ann2rr, where rr_interval is calculated with calc_rr(ann.sample, fs=ann.fs). Reproduce the behavior with annotations containing labels such as (N and (AFIB, then verify that additional annotation locations no longer create surplus intervals or alter the rhythm at those points.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
bioinformatics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.