LuaLS / LuaLS/lua-language-server

[Enhancement] Improve fun type matching

Open
#2,965 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Lua
Stars
4.4k
Forks
442
PR merge metrics
No merged PRs in 30d

Description

```lua
---@class Class
---@field f fun(s: string): integer

---@param f fun(x: string): integer
local function handle(f)
return f("string")
end

-----

---@param i number
---@return boolean
local function is_positive(i)
return i >= 0
end

handle(is_positive) -- expect `param-type-mismatch`

---@type Class
local _ = { f = is_positive } -- expect `assign-type-mismatch`
```

Expected warning:
Type `fun(i: number):boolean` cannot match `fun(x: string):integer`

I didn't find duplicates, although I expected them
maybe I didn't search well

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the Lua snippet in the issue and tracing the function-type matching path used for the call and assignment checks. Done means both mismatches produce the expected `param-type-mismatch` and `assign-type-mismatch` warnings, including the reported function types.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.