LuaLS / LuaLS/lua-language-server
`:` are not typed checked properly
Open
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 4.4k
- Forks
- 442
- PR merge metrics
- No merged PRs in 30d
Description
How are you using the lua-language-server?
Visual Studio Code Extension (sumneko.lua)
Which OS are you using?
Windows
What is the issue affecting?
Type Checking
Reproduction steps
---@param a number|string
function Foo.Bar(a)
return a:lower() -- Should warn as the code will error on a number input
end
Additional Notes
https://github.com/LuaLS/lua-language-server/issues/2708#issuecomment-2337046169
Log File
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running the Lua reproduction in the issue with the Visual Studio Code extension and inspect the type-checking path for colon calls. Done means the analyzer warns that calling lower is unsafe when a may be a number.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100