KhronosGroup / KhronosGroup/Vulkan-Tutorial

Inconsistency in chapter "Rendering Mutliple Objects" with previous chapters and crash on close

未关闭
#375 1 条评论 0 个 reaction 已指派 1 人 已被 @gpx1000 认领 在 GitHub 查看
主要语言
C++
星标
418
派生
126
平均合并
11 天 6 小时
30 天内合并 PR
31

描述

While following the chapter on "[Rendering Multiple objects](https://docs.vulkan.org/tutorial/latest/16_Multiple_Objects.html)" I noticed that in the `updateUniformBuffers()` function the up vector in `glm::lookAt` changes from Z to Y. This change isn't explained, so someone who isn't copying the whole snippet and doesn't notice the change could run into problems as in the `setupGameObjects()` function the variables are set assuming this change.

This chapter also doesn't show or tell that the `cleanup()` function was changed leading to a crash when the window is closed.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。