KhronosGroup / KhronosGroup/Vulkan-Tutorial

Inconsistency in chapter "Rendering Mutliple Objects" with previous chapters and crash on close

Abierto
#375 1 comentario 0 reacciones 1 asignado Reclamado por @gpx1000 Ver en GitHub
Lenguaje dominante
C++
Estrellas
418
Forks
126
Merge medio
11 d 6 h
PR fusionados (30 d)
31

Descripción

While following the chapter on "[Rendering Multiple objects](https://docs.vulkan.org/tutorial/latest/16_Multiple_Objects.html)" I noticed that in the `updateUniformBuffers()` function the up vector in `glm::lookAt` changes from Z to Y. This change isn't explained, so someone who isn't copying the whole snippet and doesn't notice the change could run into problems as in the `setupGameObjects()` function the variables are set assuming this change.

This chapter also doesn't show or tell that the `cleanup()` function was changed leading to a crash when the window is closed.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.