KhronosGroup / KhronosGroup/Vulkan-Tutorial

Inconsistency in chapter "Rendering Mutliple Objects" with previous chapters and crash on close

Offen
#375 1 Kommentar 0 Reaktionen 1 zugewiesene Person Beansprucht von @gpx1000 Auf GitHub ansehen
Vorherrschende Sprache
C++
Sterne
418
Forks
126
Ø Merge
11 T. 6 Std.
Gemergte PRs (30 T.)
31

Beschreibung

While following the chapter on "[Rendering Multiple objects](https://docs.vulkan.org/tutorial/latest/16_Multiple_Objects.html)" I noticed that in the `updateUniformBuffers()` function the up vector in `glm::lookAt` changes from Z to Y. This change isn't explained, so someone who isn't copying the whole snippet and doesn't notice the change could run into problems as in the `setupGameObjects()` function the variables are set assuming this change.

This chapter also doesn't show or tell that the `cleanup()` function was changed leading to a crash when the window is closed.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.