check whether numpy is installed before running Conda.add during build
- Langage dominant
- Julia
- Étoiles
- 1.5k
- Forks
- 186
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
Currently, there is a call to `Conda.add("numpy")`:
https://github.com/JuliaPy/PyCall.jl/blob/3c66d9ea6d6c2166e11dece15b12335c24648e59/deps/build.jl#L78-L80
This call should be redundant per README:
https://github.com/JuliaPy/PyCall.jl/blob/3c66d9ea6d6c2166e11dece15b12335c24648e59/README.md#L253
I suggest this call be removed, eliminating the need to access the internet when using PyCall.jl. This is an important use case in some environments.
This has also come up in #742.
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Piste de recherche
Start in deps/build.jl around lines 78–80 and compare the README guidance at its linked section. Verify when Conda.add("numpy") runs during the build and how existing environments are handled. Done means PyCall.jl no longer requires unnecessary internet access while preserving the documented NumPy setup behavior.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- julia, numpy, python
- Domaine
- build-system
- Type d'issue
- Fonctionnalité
- Difficulté
- 2/5
- Temps estimé
- 1-3 heures
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 35/100