check whether numpy is installed before running Conda.add during build
- Lenguaje dominante
- Julia
- Estrellas
- 1.5k
- Forks
- 186
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
Currently, there is a call to `Conda.add("numpy")`:
https://github.com/JuliaPy/PyCall.jl/blob/3c66d9ea6d6c2166e11dece15b12335c24648e59/deps/build.jl#L78-L80
This call should be redundant per README:
https://github.com/JuliaPy/PyCall.jl/blob/3c66d9ea6d6c2166e11dece15b12335c24648e59/README.md#L253
I suggest this call be removed, eliminating the need to access the internet when using PyCall.jl. This is an important use case in some environments.
This has also come up in #742.
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Línea de trabajo
Start in deps/build.jl around lines 78–80 and compare the README guidance at its linked section. Verify when Conda.add("numpy") runs during the build and how existing environments are handled. Done means PyCall.jl no longer requires unnecessary internet access while preserving the documented NumPy setup behavior.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- julia, numpy, python
- Área
- build-system
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100