check whether numpy is installed before running Conda.add during build
Open
- Dominant language
- Julia
- Stars
- 1.5k
- Forks
- 186
- PR merge metrics
- No merged PRs in 30d
Description
Currently, there is a call to `Conda.add("numpy")`:
https://github.com/JuliaPy/PyCall.jl/blob/3c66d9ea6d6c2166e11dece15b12335c24648e59/deps/build.jl#L78-L80
This call should be redundant per README:
https://github.com/JuliaPy/PyCall.jl/blob/3c66d9ea6d6c2166e11dece15b12335c24648e59/README.md#L253
I suggest this call be removed, eliminating the need to access the internet when using PyCall.jl. This is an important use case in some environments.
This has also come up in #742.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.