IntelliTect / IntelliTect/EssentialCSharp.Web
The hard-coded list of routes in `isContentPage` may become brittle; consider extracting the paths into a constant or config and using `Array.includes` for clarity and easier updates.
オープン
- 主要言語
- HTML
- スター
- 8
- フォーク
- 8
- 平均マージ
- 17時間 23分
- マージ済み PR(30日)
- 61
説明
[nitpick] The hard-coded list of routes in `isContentPage` may become brittle; consider extracting the paths into a constant or config and using `Array.includes` for clarity and easier updates.
```suggestion
const NON_CONTENT_ROUTES = ['/home', '/guidelines', '/about', '/announcements'];
const isContentPage = computed(() => {
let path = window.location.pathname;
return !NON_CONTENT_ROUTES.includes(path);
});
```
_Originally posted by @Copilot in https://github.com/IntelliTect/EssentialCSharp.Web/pull/667#discussion_r2198566942_
コントリビューションガイド
評価
この issue はまだ評価されていません。