IntelliTect / IntelliTect/EssentialCSharp.Web

The hard-coded list of routes in `isContentPage` may become brittle; consider extracting the paths into a constant or config and using `Array.includes` for clarity and easier updates.

Abierto
#747 0 comentarios 1 reacción 2 asignados Reclamado por @BenjaminMichaelis Ver en GitHub
Lenguaje dominante
HTML
Estrellas
8
Forks
8
Merge medio
17 h 23 min
PR fusionados (30 d)
61

Descripción

[nitpick] The hard-coded list of routes in `isContentPage` may become brittle; consider extracting the paths into a constant or config and using `Array.includes` for clarity and easier updates.
```suggestion
const NON_CONTENT_ROUTES = ['/home', '/guidelines', '/about', '/announcements'];
const isContentPage = computed(() => {
let path = window.location.pathname;
return !NON_CONTENT_ROUTES.includes(path);
});
```

_Originally posted by @Copilot in https://github.com/IntelliTect/EssentialCSharp.Web/pull/667#discussion_r2198566942_

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.