InsightSoftwareConsortium / InsightSoftwareConsortium/ITKSphinxExamples

Sort CMake install files consistently in `CMakeLists.txt` files

未关闭
#264 0 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
Good first issue type:Enhancement
主要语言
Jupyter Notebook
星标
59
派生
70
平均合并
1 天 15 小时
30 天内合并 PR
12

描述

The file list saved to the `FILES` variable to be provided to the CMake `install ` command should follow the same sorting convention to improve the consistency and readability of the `CMakeLists.txxt` files.

Currently we find both instances:
```
install(FILES Code.cxx CMakeLists.txt Code.py
```
and
```
install(FILES Code.cxx Code.py CMakeLists.txt
```

It probably makes sense to group together or list consecutively all source code files (second instance) and have `CMakeLists.txt` either at the beginning (`install(FILES CMakeLists.txt Code.cxx Code.py`) or at the end (second instance). Although the former is not used, since `CMakeLists.txt` will always be present, it is "easier" to append a filename rather than inserting it.

This is an easy change to do (although it requires manual work unless some clever script to automate the process is developed) provided that we reach consensus or establish a criterion.

贡献指南

这个仓库没有索引到贡献指南

调研方向

在仓库的 CMakeLists.txt 文件中搜索 install(FILES ...) 列表,并比较现有的排序约定。首先确定 CMakeLists.txt 应放在开头还是结尾,然后以一致的方式重新排序这些列表,并检查更改以确认没有意外遗漏文件。

由索引模型根据 Issue 内容生成。

评估

技术栈
cmake
领域
build-system
Issue 类型
重构
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
42/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。