InsightSoftwareConsortium / InsightSoftwareConsortium/ITKSphinxExamples

Sort CMake install files consistently in `CMakeLists.txt` files

Offen
#264 0 Kommentare 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen
Good first issue type:Enhancement
Vorherrschende Sprache
Jupyter Notebook
Sterne
59
Forks
70
Ø Merge
1 T. 15 Std.
Gemergte PRs (30 T.)
12

Beschreibung

The file list saved to the `FILES` variable to be provided to the CMake `install ` command should follow the same sorting convention to improve the consistency and readability of the `CMakeLists.txxt` files.

Currently we find both instances:
```
install(FILES Code.cxx CMakeLists.txt Code.py
```
and
```
install(FILES Code.cxx Code.py CMakeLists.txt
```

It probably makes sense to group together or list consecutively all source code files (second instance) and have `CMakeLists.txt` either at the beginning (`install(FILES CMakeLists.txt Code.cxx Code.py`) or at the end (second instance). Although the former is not used, since `CMakeLists.txt` will always be present, it is "easier" to append a filename rather than inserting it.

This is an easy change to do (although it requires manual work unless some clever script to automate the process is developed) provided that we reach consensus or establish a criterion.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.