InsightSoftwareConsortium / InsightSoftwareConsortium/ITKSphinxExamples

Sort CMake install files consistently in `CMakeLists.txt` files

Abierto
#264 0 comentarios 1 reacción 0 asignados Ver en GitHub
Good first issue type:Enhancement
Lenguaje dominante
Jupyter Notebook
Estrellas
59
Forks
70
Merge medio
1 d 15 h
PR fusionados (30 d)
12

Descripción

The file list saved to the `FILES` variable to be provided to the CMake `install ` command should follow the same sorting convention to improve the consistency and readability of the `CMakeLists.txxt` files.

Currently we find both instances:
```
install(FILES Code.cxx CMakeLists.txt Code.py
```
and
```
install(FILES Code.cxx Code.py CMakeLists.txt
```

It probably makes sense to group together or list consecutively all source code files (second instance) and have `CMakeLists.txt` either at the beginning (`install(FILES CMakeLists.txt Code.cxx Code.py`) or at the end (second instance). Although the former is not used, since `CMakeLists.txt` will always be present, it is "easier" to append a filename rather than inserting it.

This is an easy change to do (although it requires manual work unless some clever script to automate the process is developed) provided that we reach consensus or establish a criterion.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.