InsightSoftwareConsortium / InsightSoftwareConsortium/ITKPythonPackage
Update Windows script argument parsing to match Linux and macOS
- 主要语言
- CMake
- 星标
- 66
- 派生
- 25
- 平均合并
- 1 天 18 小时
- 30 天内合并 PR
- 2
描述
## Summary
Linux and macOS module build scripts accept "-c" and "-x" command line options along with positional arguments for Python versions and assorted environment variables documented in script headers. See [manylinux-build-module-wheels.sh](https://github.com/InsightSoftwareConsortium/ITKPythonPackage/blob/master/scripts/internal/manylinux-build-module-wheels.sh#L32)) for parsing.
Meanwhile Windows scripts use a different convention with distinct long arguments and trailing CMake parameters to accomplish the same functionality. See [windows_build_module_wheels.py](https://github.com/InsightSoftwareConsortium/ITKPythonPackage/blob/master/scripts/windows_build_module_wheels.py#L134).
The following changes are requested:
1. Update Windows script argument handling to match conventions laid out in Linux and macOS scripts
2. If necessary, introduce arguments from Windows script parsing back to Linux and macOS scripts
## Other Notes
See original discussion: https://github.com/InsightSoftwareConsortium/ITKPythonPackage/pull/248#discussion_r1065407914
贡献指南
这个仓库没有索引到贡献指南
调研方向
Compare argument handling in scripts/windows_build_module_wheels.py with the conventions and documented headers in scripts/internal/manylinux-build-module-wheels.sh and the macOS build script. Start at the referenced parsing sections, then verify that the Windows, Linux, and macOS scripts accept the agreed options, positional arguments, environment variables, and CMake parameters consistently.
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- cmake, python, shell
- 领域
- build-system
- Issue 类型
- 功能
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 42/100