InsightSoftwareConsortium / InsightSoftwareConsortium/ITKPythonPackage

Update Windows script argument parsing to match Linux and macOS

Offen
#250 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
CMake
Sterne
66
Forks
25
Ø Merge
1 T. 18 Std.
Gemergte PRs (30 T.)
2

Beschreibung

## Summary

Linux and macOS module build scripts accept "-c" and "-x" command line options along with positional arguments for Python versions and assorted environment variables documented in script headers. See [manylinux-build-module-wheels.sh](https://github.com/InsightSoftwareConsortium/ITKPythonPackage/blob/master/scripts/internal/manylinux-build-module-wheels.sh#L32)) for parsing.

Meanwhile Windows scripts use a different convention with distinct long arguments and trailing CMake parameters to accomplish the same functionality. See [windows_build_module_wheels.py](https://github.com/InsightSoftwareConsortium/ITKPythonPackage/blob/master/scripts/windows_build_module_wheels.py#L134).

The following changes are requested:
1. Update Windows script argument handling to match conventions laid out in Linux and macOS scripts
2. If necessary, introduce arguments from Windows script parsing back to Linux and macOS scripts

## Other Notes

See original discussion: https://github.com/InsightSoftwareConsortium/ITKPythonPackage/pull/248#discussion_r1065407914

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.