InsightSoftwareConsortium / InsightSoftwareConsortium/ITKPythonPackage

Update Windows script argument parsing to match Linux and macOS

Open
#250 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
CMake
Stars
66
Forks
25
Avg merge
1d 18h
Merged PRs (30d)
2

Description

## Summary

Linux and macOS module build scripts accept "-c" and "-x" command line options along with positional arguments for Python versions and assorted environment variables documented in script headers. See [manylinux-build-module-wheels.sh](https://github.com/InsightSoftwareConsortium/ITKPythonPackage/blob/master/scripts/internal/manylinux-build-module-wheels.sh#L32)) for parsing.

Meanwhile Windows scripts use a different convention with distinct long arguments and trailing CMake parameters to accomplish the same functionality. See [windows_build_module_wheels.py](https://github.com/InsightSoftwareConsortium/ITKPythonPackage/blob/master/scripts/windows_build_module_wheels.py#L134).

The following changes are requested:
1. Update Windows script argument handling to match conventions laid out in Linux and macOS scripts
2. If necessary, introduce arguments from Windows script parsing back to Linux and macOS scripts

## Other Notes

See original discussion: https://github.com/InsightSoftwareConsortium/ITKPythonPackage/pull/248#discussion_r1065407914

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.