HelloZeroNet / HelloZeroNet/ZeroNet
Second instance will continue running even if port is already taken
- Ngôn ngữ chính
- JavaScript
- Star
- 18.8k
- Fork
- 2.3k
- Chỉ số merge pull request
- Không có pull request nào được merge trong 30 ngày
Mô tả
### Describe your environment
* ZeroNet version: 0.7.0
* Operating system: Windows 10
* First instance: `C:\Users\filips\AppData\Local\Programs\ZeroNet`
* Second instance: `D:\Users\filips\Namizje\ZeroNet-win-dist-win64`
### Describe the problem
#### Steps to reproduce
1. Create first ZeroNet instance.
2. Confirm that it works.
3. Create a second ZeroNet instance with the same port.
4. It will continue running even if the port is already taken.
#### Observed results
The second instance will try to start. It will fail because the port for a server is already taken by the first instance.
But for some reason, the process of the second instance won't be killed so it will be still running, but without any usability.
When you will try to open the server of the second instance, it will actually use the first one.
[Here](https://pastebin.com/Vgz9xR64) is my debug log of the second instance. As you can see, it will detect that port is already taken and stop UiServer. But the process will be still running until I manually kill it from Task Manager.
This issue is mostly based on [this Reddit topic](https://www.reddit.com/r/zeronet/comments/c045z2/disallow_running_a_second_instance/).
#### Expected results
The second instance should detect that port is already taken, inform the user and then stop itself.
Hướng dẫn đóng góp
Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này
Hướng nghiên cứu
Reproduce on Windows 10 by starting two ZeroNet instances with the same server port, then review the linked debug log for the second instance. Confirm that the port conflict is reported and that UiServer stops, while the process remains alive. Done means the second instance informs the user and exits instead of continuing to run.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Đánh giá
- Lĩnh vực
- backend, networking
- Loại issue
- Lỗi
- Độ khó
- 3/5
- Thời gian dự kiến
- 1-2 ngày
- Mức độ hoạt động
- Đình trệ
- Độ rõ ràng
- Khá rõ ràng
- Mức phù hợp với người mới
- 35/100