HelloZeroNet / HelloZeroNet/ZeroNet

Second instance will continue running even if port is already taken

オープン
#2,065 コメント 4 件 リアクション 0 件 担当者 0 名 GitHub で見る
bug
主要言語
JavaScript
スター
18.8k
フォーク
2.3k
PR マージ指標
30日以内にマージされた PR はありません

説明

### Describe your environment

* ZeroNet version: 0.7.0
* Operating system: Windows 10

* First instance: `C:\Users\filips\AppData\Local\Programs\ZeroNet`
* Second instance: `D:\Users\filips\Namizje\ZeroNet-win-dist-win64`

### Describe the problem

#### Steps to reproduce

1. Create first ZeroNet instance.
2. Confirm that it works.
3. Create a second ZeroNet instance with the same port.
4. It will continue running even if the port is already taken.

#### Observed results

The second instance will try to start. It will fail because the port for a server is already taken by the first instance.

But for some reason, the process of the second instance won't be killed so it will be still running, but without any usability.

When you will try to open the server of the second instance, it will actually use the first one.

[Here](https://pastebin.com/Vgz9xR64) is my debug log of the second instance. As you can see, it will detect that port is already taken and stop UiServer. But the process will be still running until I manually kill it from Task Manager.

This issue is mostly based on [this Reddit topic](https://www.reddit.com/r/zeronet/comments/c045z2/disallow_running_a_second_instance/).

#### Expected results

The second instance should detect that port is already taken, inform the user and then stop itself.

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。