GraphiteEditor / GraphiteEditor/Graphite

Rewrite the Path tool's transaction management logic in delete messages

Open
#3,158 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
27.3k
Forks
1.3k
Avg merge
20h 5m
Merged PRs (30d)
57

Description

https://github.com/GraphiteEditor/Graphite/pull/3111 attempts to fix the broken transactions and undo history when performing delete operations in the path tool. The issue is resolved but this is not the ideal way of implementing it correctly (currently it is passing flags between different methods). This should be re written.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review PR #3111 and the current Path tool delete-message transaction flow first. Identify how transaction and undo-history handling is split across methods; done means delete operations retain correct transaction and undo behavior without the current flag-passing approach.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
computer-graphics, design
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.