GraphiteEditor / GraphiteEditor/Graphite
Ad-hoc graph introspection instead of Monitor nodes for thumbnails and click targets
- 主要言語
- Rust
- スター
- 27.2k
- フォーク
- 1.3k
- 平均マージ
- 20時間 5分
- マージ済み PR(30日)
- 57
説明
Latest plans call for removing the *Monitor* node approach of extracting thumbnail data and instead executing the graph to obtain the thumbnail with specific bounds that it prefers, as well as potentially other `Context` values specific to the individual render of the thumbnail (or a user-requested thumbnail render from within the dialog that shows up when expanding a thumbnail into a graph value diagnostics interface).
---
Old issue description when this was titled "Automatic monitor node insertion":
In order to display thumbnails for every wire, a Monitor node should be placed at outputs during compilation. The number of monitor nodes should be minimized to avoid redundant clones as data flows through the graph. The outputs would be selected based on which thumbnails should be rendered, both in the node graph UI and layer panel. This would also improve #2028 and getting artboard translations in the [Clear Artboards PR](https://github.com/GraphiteEditor/Graphite/pull/2015).
Monitor nodes will be the standard way of getting data from the node graph, as opposed to the render output. This is because the render output does not include all data in the node graph due to destructive operations like rasterize or boolean operations. We currently work around this by redundantly storing the upstream graphic group for vector data created by a boolean operation, but this is not ideal. (This is something that is still currently being discussed)
https://discord.com/channels/731730685944922173/731738914812854303/1291860544604602439
https://discord.com/channels/731730685944922173/731738914812854303/1291830448195899527
コントリビューションガイド
このリポジトリのコントリビューションガイドは索引されていません
調査の方向性
ファイルやテストは指定されていません。まず現在の Monitor-node のサムネイルとクリック対象の経路を追跡し、それらをグラフ実行および関連する Context の値と比較します。合意したアプローチによって Monitor の ad-hoc な抽出が置き換えられ、UI のサムネイル、クリック対象、要求された診断用レンダーがカバーされれば、作業は完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- rust
- 領域
- computer-graphics
- issue の種類
- 機能追加
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 活発さ
- 停滞
- 明瞭さ
- 説明が足りない
- 初心者へのやさしさ
- 25/100