GraphiteEditor / GraphiteEditor/Graphite

Ad-hoc graph introspection instead of Monitor nodes for thumbnails and click targets

Ouverte
#2,044 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Graphene
Langage dominant
Rust
Étoiles
27.2k
Forks
1.3k
Merge moyen
20 h 5 min
PR mergées (30 j)
57

Description

Latest plans call for removing the *Monitor* node approach of extracting thumbnail data and instead executing the graph to obtain the thumbnail with specific bounds that it prefers, as well as potentially other `Context` values specific to the individual render of the thumbnail (or a user-requested thumbnail render from within the dialog that shows up when expanding a thumbnail into a graph value diagnostics interface).

---

Old issue description when this was titled "Automatic monitor node insertion":

In order to display thumbnails for every wire, a Monitor node should be placed at outputs during compilation. The number of monitor nodes should be minimized to avoid redundant clones as data flows through the graph. The outputs would be selected based on which thumbnails should be rendered, both in the node graph UI and layer panel. This would also improve #2028 and getting artboard translations in the [Clear Artboards PR](https://github.com/GraphiteEditor/Graphite/pull/2015).

Monitor nodes will be the standard way of getting data from the node graph, as opposed to the render output. This is because the render output does not include all data in the node graph due to destructive operations like rasterize or boolean operations. We currently work around this by redundantly storing the upstream graphic group for vector data created by a boolean operation, but this is not ideal. (This is something that is still currently being discussed)

https://discord.com/channels/731730685944922173/731738914812854303/1291860544604602439
https://discord.com/channels/731730685944922173/731738914812854303/1291830448195899527

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Piste de recherche

Aucun fichier ni test n’est nommé. Commencez par suivre les chemins actuels des thumbnails et des cibles de clic de Monitor-node, puis comparez-les à l’exécution du graphe et aux valeurs pertinentes de Context ; le travail est terminé lorsque l’approche convenue remplace l’extraction ad-hoc de Monitor et couvre les thumbnails de l’UI, les cibles de clic et les rendus de diagnostic demandés.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
rust
Domaine
computer-graphics
Type d'issue
Fonctionnalité
Difficulté
5/5
Temps estimé
Plus d'une semaine
Activité
À l'abandon
Clarté
À clarifier
Accessibilité débutants
25/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.