GraphiteEditor / GraphiteEditor/Graphite

Path nodes should be able to edit multiple vector table rows

Open
#1,822 0 comments 0 reactions 0 assignees View on GitHub
Graphene Paper Cut
Dominant language
Rust
Stars
27.2k
Forks
1.3k
Avg merge
20h 5m
Merged PRs (30d)
57

Description

The *Path* (vector modify) node must store modifications for each shape's element ID now that we support multiple rows of vector data thanks to the work in #1834.

For now, we can do this based on index:

> you'd need a `HashMap` which would require refactoring all of the tools

(we don't have `RowId` yet, so we can use `usize` for its row index instead: `HashMap`)

In the future, we can attempt a smarter way of generating unique IDs: #1821.

Related: #1929.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the Path (vector modify) node and how it stores VectorModification data, then review the multiple-row vector work in #1834. Update the storage so each shape element index retains its own modification; done means edits to multiple vector table rows remain independent.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
computer-graphics
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.