GoogleCloudPlatform / GoogleCloudPlatform/ruby-docs-samples

bookshelf: missing Gemfile.lock, missing updates

Aperta
#1,613 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
samples
Lingua principale
Ruby
Stelle
235
Fork
210
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Multiple errors recurring on getting-started/bookshelf nightly tests, which reports argument and nomethod errors on dependencies

```
An error occurred while loading ./spec/features/book_management_spec.rb.
Failure/Error: require File.expand_path("../../config/environment", __FILE__)

ArgumentError:
wrong number of arguments (given 3, expected 2)
# ./config/environment.rb:18:in `'
# ./spec/spec_helper.rb:17:in `'
# ./spec/features/book_management_spec.rb:14:in `'

An error occurred while loading ./spec/models/book_spec.rb.
Failure/Error: require File.expand_path("../../config/environment", __FILE__)

NoMethodError:
undefined method `operations' for #

MiddlewareStackProxy.new(@operations + other.operations, @delete_operations + other.delete_operations)
^^^^^^^^^^^
# ./config/environment.rb:18:in `'
# ./spec/spec_helper.rb:17:in `'
# ./spec/models/book_spec.rb:14:in `'
No examples found.
```

It looks like dependabot isn't updating this sample. There's no committed Gemfile.lock, that is being updated in other samples.

It's stuck with a very out dated version of Rails which isn't supported on the current Ruby Oldest (https://www.fastruby.io/blog/ruby/rails/versions/compatibility-table.html)

This sample would need to be updated to latest Rails versions and manually updated if any updates required for mulitple major version updates.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.