GoogleCloudPlatform / GoogleCloudPlatform/ruby-docs-samples

bookshelf: missing Gemfile.lock, missing updates

Offen
#1,613 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
samples
Vorherrschende Sprache
Ruby
Sterne
235
Forks
210
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Multiple errors recurring on getting-started/bookshelf nightly tests, which reports argument and nomethod errors on dependencies

```
An error occurred while loading ./spec/features/book_management_spec.rb.
Failure/Error: require File.expand_path("../../config/environment", __FILE__)

ArgumentError:
wrong number of arguments (given 3, expected 2)
# ./config/environment.rb:18:in `'
# ./spec/spec_helper.rb:17:in `'
# ./spec/features/book_management_spec.rb:14:in `'

An error occurred while loading ./spec/models/book_spec.rb.
Failure/Error: require File.expand_path("../../config/environment", __FILE__)

NoMethodError:
undefined method `operations' for #

MiddlewareStackProxy.new(@operations + other.operations, @delete_operations + other.delete_operations)
^^^^^^^^^^^
# ./config/environment.rb:18:in `'
# ./spec/spec_helper.rb:17:in `'
# ./spec/models/book_spec.rb:14:in `'
No examples found.
```

It looks like dependabot isn't updating this sample. There's no committed Gemfile.lock, that is being updated in other samples.

It's stuck with a very out dated version of Rails which isn't supported on the current Ruby Oldest (https://www.fastruby.io/blog/ruby/rails/versions/compatibility-table.html)

This sample would need to be updated to latest Rails versions and manually updated if any updates required for mulitple major version updates.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.