GoogleCloudPlatform / GoogleCloudPlatform/ruby-docs-samples
bookshelf: missing Gemfile.lock, missing updates
- Langage dominant
- Ruby
- Étoiles
- 235
- Forks
- 210
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
Multiple errors recurring on getting-started/bookshelf nightly tests, which reports argument and nomethod errors on dependencies
```
An error occurred while loading ./spec/features/book_management_spec.rb.
Failure/Error: require File.expand_path("../../config/environment", __FILE__)
ArgumentError:
wrong number of arguments (given 3, expected 2)
# ./config/environment.rb:18:in `'
# ./spec/spec_helper.rb:17:in `'
# ./spec/features/book_management_spec.rb:14:in `'
An error occurred while loading ./spec/models/book_spec.rb.
Failure/Error: require File.expand_path("../../config/environment", __FILE__)
NoMethodError:
undefined method `operations' for #
MiddlewareStackProxy.new(@operations + other.operations, @delete_operations + other.delete_operations)
^^^^^^^^^^^
# ./config/environment.rb:18:in `'
# ./spec/spec_helper.rb:17:in `'
# ./spec/models/book_spec.rb:14:in `'
No examples found.
```
It looks like dependabot isn't updating this sample. There's no committed Gemfile.lock, that is being updated in other samples.
It's stuck with a very out dated version of Rails which isn't supported on the current Ruby Oldest (https://www.fastruby.io/blog/ruby/rails/versions/compatibility-table.html)
This sample would need to be updated to latest Rails versions and manually updated if any updates required for mulitple major version updates.
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Commencez par getting-started/bookshelf/config/environment.rb et la configuration des dépendances, puis exécutez les specs en échec dans spec/features/book_management_spec.rb et spec/models/book_spec.rb. Mettez à jour les dépendances Rails de l’exemple et faites un commit de son Gemfile.lock, puis vérifiez que les tests nocturnes ne signalent plus les erreurs de chargement.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- rails, ruby
- Domaine
- backend, testing
- Type d'issue
- Refactorisation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 45/100